[chore] bump dependencies #7520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Asset Size Report for c673682 IE11 Builds 🛑 The size of the library EmberData has increased by +542.0 B (+163.0 B compressed) which exceeds the failure threshold of 75 bytes.Warnings
Changeset Full Asset Analysis (IE11)Modern Builds 🛑 The size of the library EmberData has increased by +611.0 B (+174.0 B compressed) which exceeds the failure threshold of 75 bytes.Warnings
Changeset Full Asset Analysis (Modern)Modern Builds (No Rollup) 🛑 The size of the library EmberData has increased by +1.26 KB (+202.0 B compressed) which exceeds the failure threshold of 75 bytes.Warnings
Changeset Full Asset Analysis (Modern) |
runspired
force-pushed
the
chore/bump-ember
branch
from
f15fd78
to
a6af60b
Compare
runspired
changed the title
|
Performance Report for c673682 Scenario - materialization:
|
runspired
force-pushed
the
chore/bump-ember
branch
from
d38ef85
to
aec99a8
Compare
runspired
commented
May 20, 2021
runspired
commented
May 20, 2021
| @@ -22,7 +22,8 @@ import Store, { | |||
| import { identifierCacheFor } from '@ember-data/store/-private'; | |||
|
|
|||
| type StableRecordIdentifier = import('@ember-data/store/-private/ts-interfaces/identifier').StableRecordIdentifier; | |||
| type ExistingResourceObject = import('@ember-data/store/-private/ts-interfaces/ember-data-json-api').ExistingResourceObject; | |||
| type ExistingResourceObject = | |||
| import('@ember-data/store/-private/ts-interfaces/ember-data-json-api').ExistingResourceObject; | |||
|
|
|||
There was a problem hiding this comment.
in-range updates to lint and prettier enforce the max-line-length for these type declarations now (they didn't before) which is why some of them now split lines.
runspired
commented
May 20, 2021
| tag: Tag; | ||
| owner: any; |
There was a problem hiding this comment.
this was typed as any already, and there is no import for it yet in ember-qunit 5 (ember-test-helpers is not available in the ember-qunit 5 world)
runspired
commented
May 20, 2021
| @@ -889,53 +887,6 @@ module('integration/relationship/belongs_to Belongs-To Relationships', function | |||
| assert.ok(comment instanceof Message, 'a comment is an instance of a message'); | |||
| }); | |||
|
|
|||
| test('relationshipsByName does not cache a factory', async function (assert) { | |||
There was a problem hiding this comment.
this test covered a case where in pre 1.x versions of ember-data we stashed the factory onto relationship meta directly as the type field. It has not been the case that we do this since. The type field today is a string and other tests would fail were it not. This test no longer has value, so I removed it.
That said, it also failed because the this context of the test is registered as a destroyable by setupTest and thus cannot be torndown and then reused. We don't have any other tests like this but if we ever add one the solution is to not use setupTest at all for this test and to instead setupContext/teardownContext with objects we control.
runspired
commented
May 20, 2021
| // Handle testing feature flags | ||
| if (QUnit.urlParams.enableoptionalfeatures) { | ||
| window.EmberDataENV = { ENABLE_OPTIONAL_FEATURES: true }; | ||
| } |
There was a problem hiding this comment.
this used to be in the tests/index.html file but QUnit is no longer a global.
runspired
commented
May 20, 2021
| @@ -10,6 +10,8 @@ module.exports = Object.assign({}, addonBaseConfig, { | |||
| shouldRollupPrivate: true, | |||
| externalDependenciesForPrivateModule() { | |||
| return [ | |||
| 'ember-cached-decorator-polyfill', | |||
There was a problem hiding this comment.
the polyfill rewrites the import from @glimmer/tracking to be from itself so we declare it here now.
runspired
commented
May 20, 2021
runspired
added
the
🏷️ chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
node: 'current'to targets for fastboot builds.In the process we pick up a drift of prettier that causes the bulk of the line changes here due to a change in the formatting of some code.